Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133587 / 25.04 / Use system generated cert after TNC has been revoked #15403

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Jan 15, 2025

This PR adds changes to default back to system generated cert for TrueNAS once TNC has been disabled. We have logic in place which will see if system generated cert is still valid i.e not expired and if it is not use it, otherwise generate a new one and consume it.

@sonicaj sonicaj requested review from ZackaryWelch and a team January 15, 2025 19:44
@sonicaj sonicaj self-assigned this Jan 15, 2025
@bugclerk bugclerk changed the title Use system generated cert after TNC has been revoked NAS-133587 / 25.04 / Use system generated cert after TNC has been revoked Jan 15, 2025
@bugclerk
Copy link
Contributor

@truenas truenas deleted a comment from bugclerk Jan 15, 2025
@sonicaj sonicaj merged commit 783b35e into master Jan 16, 2025
2 checks passed
@sonicaj sonicaj deleted the change-cert-on-unsetting-tnc branch January 16, 2025 17:46
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants