NAS-134606 / 25.10 / restrict changes to builtin groups #15908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
reviewed
Mar 5, 2025
bugclerk
changed the title
yocalebo
approved these changes
Mar 5, 2025
Historically TrueNAS has done little to limit the changes admins can make to builtin groups. This usually isn't problematic because admins know enough to not alter builtin groups because it can cause undefined system behavior including introducing security vulnerabilities. This commit introduces additional validation to prevent problematic changes to these special system groups.
anodos325
force-pushed
the
restrict-builtin-group-changes
branch
from
74e89df to
373543e
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically TrueNAS has done little to limit the changes admins can make to builtin groups (root, sssd, ntp, sudo, etc). This usually isn't problematic because admins know enough to not alter builtin groups. This is because changes to them can cause undefined system behavior, including introducing security vulnerabilities. This commit introduces additional validation to prevent problematic changes to these special system groups.