NAS-137734 / 26.04 / Get cpu temperatures from sysfs #17261
+806
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
themylogin
approved these changes
Sep 26, 2025
yocalebo
requested changes
Sep 26, 2025
There was a problem hiding this comment.
Let's either:
- copy over
lm_sensorspython script from netdata - write our own wrapper around lib sensors library
The changes introduced here are extremely less efficient than what we were previously doing. I've sent you a libsensors ctypes wrapper so let's test that and see what we come up with.
Qubad786
force-pushed
the
mrehan/fix-cpu-temp-plugin
branch
from
c15081d to
45f8c62
Compare
yocalebo
requested changes
Oct 2, 2025
| Example: {'coretemp-isa-0000': {'Core 0': 48.0}, 'k10temp-pci-00c3': {'Tctl': 67.0}} | ||
| """ | ||
| with contextlib.suppress(OSError, RuntimeError): | ||
| with SensorsWrapper() as sensors: |
There was a problem hiding this comment.
By using the context manager, it's doing a bunch of CDDL setup functions each time it's called which is painful and unnecessary. We should instantiate a sensors = SensorsWrapper() object once and then just do sensors.get_cpu_temperatures()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With newer netdata, we don't have netdata's bindings of
lm_sensoranymore which means cpu temperature plugin in master is broken right now.Solution
We can get the same information from sysfs directly and make sure our netdata plugin reflects the temperature stats accurately.