NAS-137535 / 26.04 / Code cleanup #17296
Closed
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
reviewed
Sep 30, 2025
|
How does this fix the ticket that you've linked the PR to? |
|
@yocalebo the original ticket was already fixed, as I stated in the PR description. Should we merge these minor fixes that we make during the investigation of the issue as separate JIRA issue PRs? |
yes because the PR here makes it look like the error message that the end-user receives is resolved by these changes and that's not correct. You should close the NAS ticket as a duplicate of the actual ticket that fixes this and then open separate tickets for changes like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was resolved with the rewrite of
path_in_locked_datasetsin 25.10.This is the minor fixes I made during the investigation of the issue.