Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131461 / 25.04 / Listen for apps stats only when have installed apps #10791

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

Listen for apps stats only when have installed apps

Testing:

Check websocket messages

@denysbutenko denysbutenko requested a review from a team as a code owner October 3, 2024 05:01
@denysbutenko denysbutenko requested review from undsoft and removed request for a team October 3, 2024 05:01
@bugclerk bugclerk changed the title Nas 131461 NAS-131461 / 25.04 / Nas 131461 Oct 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Oct 3, 2024

@denysbutenko denysbutenko changed the title NAS-131461 / 25.04 / Nas 131461 Listen for apps stats only when have installed apps Oct 3, 2024
@denysbutenko denysbutenko changed the title Listen for apps stats only when have installed apps NAS-131461 / 25.04 / Listen for apps stats only when have installed apps Oct 3, 2024
@denysbutenko denysbutenko added the backport-24.10 Electric Eel MS1 label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (303e5cc) to head (2a833a6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...p/pages/apps/store/installed-apps-store.service.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10791      +/-   ##
==========================================
- Coverage   80.91%   80.90%   -0.01%     
==========================================
  Files        1571     1572       +1     
  Lines       52114    52169      +55     
  Branches     5812     5807       -5     
==========================================
+ Hits        42167    42208      +41     
- Misses       9947     9961      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.installedApps$ will emit every time there is a change to installed apps, leading to more and more subscriptions.

@denysbutenko
Copy link
Member Author

this.installedApps$ will emit every time there is a change to installed apps, leading to more and more subscriptions.

No extra subscriptions are seen in websocket. Changed operator to tapOnce anyway.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.10 Electric Eel MS1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants