Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131147 / 25.04 / Allow to edit yaml installed apps #10804

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

Allow to edit app that was installed via YAML docker compose

Testing:

Install an app via YAML and try to edit it.

@denysbutenko denysbutenko requested a review from a team as a code owner October 4, 2024 09:47
@denysbutenko denysbutenko requested review from bvasilenko and removed request for a team October 4, 2024 09:47
@bugclerk bugclerk changed the title NAS-131147: Allow to edit yaml installed apps NAS-131147 / 25.04 / Allow to edit yaml installed apps Oct 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (8ef7ab6) to head (2726dcb).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...apps/components/app-wizard/app-wizard.component.ts 61.90% 8 Missing ⚠️
src/app/helpers/json-to-yaml.helper.ts 33.33% 4 Missing ⚠️
...nents/custom-app-form/custom-app-form.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10804      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files        1572     1572              
  Lines       52161    52209      +48     
  Branches     5807     5812       +5     
==========================================
+ Hits        42203    42235      +32     
- Misses       9958     9974      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants