NAS-133723 / 25.10 / Adds "Enable VLAN" checkbox and sends null when disabled #11495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11495 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 1654 1654
Lines 59091 59092 +1
Branches 6353 6353
=======================================
+ Hits 49207 49211 +4
+ Misses 9884 9881 -3 ☔ View full report in Codecov by Sentry. |
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133723 is targeted to the following versions which have not received their corresponding PRs: 25.04-RC.1 |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adds an "Enable VLAN" checkbox to the ipmi form. If the checkbox is unchecked, UI should send null value in the "vlan" field when calling middleware endpoint. When the checkbox is checked, the vlan id field is required.
Testing:
Check that vlan id is disabled, enabled and set correctly.