Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134102 / 25.10 / More strict null checks #11519

Merged
merged 1 commit into from
Feb 10, 2025
Merged

NAS-134102 / 25.10 / More strict null checks #11519

merged 1 commit into from
Feb 10, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Feb 8, 2025

Changes:

Code review and shallow regression testing.

@undsoft undsoft requested a review from a team as a code owner February 8, 2025 01:05
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team February 8, 2025 01:05
@bugclerk bugclerk changed the title NAS-134102: More strict null checks NAS-134102 / 25.10 / More strict null checks Feb 8, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Feb 8, 2025

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 75.40984% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (8c9931d) to head (466eb1c).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...dules/lists/ordered-list/ordered-list.component.ts 0.00% 6 Missing ⚠️
...les/page-header/breadcrumb/breadcrumb.component.ts 33.33% 2 Missing ⚠️
...apps/components/app-wizard/app-wizard.component.ts 33.33% 2 Missing ⚠️
...-dataset-dialog/create-dataset-dialog.component.ts 50.00% 1 Missing ⚠️
...ork/widget-interface/widget-interface.component.ts 50.00% 1 Missing ⚠️
...ions-section/name-and-options-section.component.ts 50.00% 1 Missing ⚠️
...les/permissions/stores/dataset-acl-editor.store.ts 0.00% 1 Missing ⚠️
...omponents/configuration/configuration.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11519      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.01%     
==========================================
  Files        1652     1652              
  Lines       58999    59011      +12     
  Branches     6323     6344      +21     
==========================================
+ Hits        49117    49124       +7     
- Misses       9882     9887       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks and works good 👍

@undsoft undsoft merged commit c6e8752 into master Feb 10, 2025
9 checks passed
@undsoft undsoft deleted the NAS-134102 branch February 10, 2025 14:18
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants