Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133675 / 25.04-RC.1 / Refactor CloudBackupListComponent to master-detail-view (by denysbutenko) #11525

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 0930eb80c5266aee3f6ba688a0e72f5a2fa9d69f
git cherry-pick -x d742b0e7c0995f25627d7cbbc6267456c6a3958f
git cherry-pick -x 716dafce47db132b7bc9772d8c19ef7e6440eae8
git cherry-pick -x db1ed7bcd30cfe1dcc485687bd057b7a95327e68
git cherry-pick -x 4b3acb8bbec3aad2538f7163eaccff334927d2e8
git cherry-pick -x b8494cc62ec0c521f6624f02e35636cf3a103992
git cherry-pick -x 94303d12c1f96036825823fcd520f588a6e5836a
git cherry-pick -x 1fbdc9fef73402a4cc98d455ef2f9349168f5ca3
git cherry-pick -x 2bd276f58af8847e9e35d030841ef4fc4098f583
git cherry-pick -x a37df00ec8515e830f594fc91589a94a9fc8caa7
git cherry-pick -x b72879839ab8824431e990d024ec32bf6f7935b7
git cherry-pick -x d19eb366a8c3b9f9ebd8cee9e5f6c89ee999c846
git cherry-pick -x cf75a52441646fdce85b2ddd81b8569c6a83f9c3
git cherry-pick -x 128f8fd7be11adfd2e4b0afd25937c9a2f505c11
git cherry-pick -x be0d43004cbc4542cb47c7cfb194c1ebbfaeeb4b

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x fd36ee9e5cd5f06861bdfbc9da601a8e1520b08d

Changes:

  • Refactor CloudBackupListComponent to master-detail-view

Testing:

Check page at /data-protection/cloud-backup

Downstream

Affects Reasoning
Documentation refactoring, screenshot may need updated

Original PR: #11429
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133675

…11429)

* NAS-133675: Refactor CloudBackupListComponent to master-detail-view

* NAS-133675: Refactor CloudBackupListComponent to master-detail-view

* NAS-133675: Refactor CloudBackupListComponent to master-detail-view

* NAS-133675: Refactor CloudBackupListComponent to master-detail-view

* NAS-133675: Skip tests

* NAS-133675: Update

* NAS-133675: Listen for cloudbackup changes

* NAS-133675: Listen for cloudbackup changes

* NAS-133675: Update tests

* NAS-133675: Update tests

(cherry picked from commit fd36ee9)
@denysbutenko denysbutenko marked this pull request as ready for review February 10, 2025 08:21
@denysbutenko denysbutenko requested a review from a team as a code owner February 10, 2025 08:21
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team February 10, 2025 08:21
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 79.76190% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@7962fcf). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/cloud-backup-list/cloud-backup-list.component.ts 61.53% 10 Missing ⚠️
...p/all-cloud-backups/all-cloud-backups.component.ts 89.47% 6 Missing ⚠️
...pp/pages/data-protection/data-protection.routes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11525   +/-   ##
===================================================
  Coverage                    ?   82.91%           
===================================================
  Files                       ?     1652           
  Lines                       ?    58895           
  Branches                    ?     6232           
===================================================
  Hits                        ?    48833           
  Misses                      ?    10062           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko denysbutenko merged commit 59ecdf6 into stable/fangtooth Feb 10, 2025
9 checks passed
@denysbutenko denysbutenko deleted the NAS-133675-25.04-RC.1 branch February 10, 2025 08:49
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants