NAS-134061 / 25.10 / Apps - UI validates uri type more strictly than middleware
#11530
Conversation
bugclerk
changed the title
uri type more strictly than middlewareuri type more strictly than middleware
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11530 +/- ##
==========================================
- Coverage 83.27% 83.27% -0.01%
==========================================
Files 1654 1654
Lines 59081 59081
Branches 6352 6352
==========================================
- Hits 49200 49197 -3
- Misses 9881 9884 +3 ☔ View full report in Codecov by Sentry. |
| @@ -2,5 +2,5 @@ import { Injectable } from '@angular/core'; | |||
|
|
|||
| @Injectable({ providedIn: 'root' }) | |||
| export class UrlValidationService { | |||
| urlRegex = /^(?:http(s)?:\/\/)?[\w.-]+(?:\.[\w.-]+)+[\w\-._~:/?#[\]@!$&'()*+,;=.]+$/; | |||
| urlRegex = /^(https?|ftp|mqtt|ws|wss):\/\/([a-zA-Z0-9.-]+)(:[0-9]+)?(\/.*)?$/; | |||
There was a problem hiding this comment.
Can we update regexp to match whatever://anything?
This still won't allow for some URLs.
There was a problem hiding this comment.
Can we update regexp to match
whatever://anything? This still won't allow for some URLs.
I'll check. In this case it's really a wild card 😃
There was a problem hiding this comment.
I updated it + tests.
|
This PR has been merged and conversations have been locked. |
Testing: see ticket.
Result, no validation error: