Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133963 / 25.04-RC.1 / Conditionally disable Secure Boot checkbox in VMs (by AlexKarpov98) #11544

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 7e019d3e54be752e1099330236a0502b6fef3bae
git cherry-pick -x c2e782353505646cd59b02948c9aa5e180a341e9
git cherry-pick -x e966b50f794f4290897ba0be004da6405e2c94dd
git cherry-pick -x a9d74153924084a55a58579c90c5f53f497a8989

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 6df85fc5341696dea4481ace2dfbfbd849369604

Testing: see ticket.

Result:

Screen.Recording.2025-02-07.at.13.12.49.mov

Original PR: #11527
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133963

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review February 13, 2025 14:53
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner February 13, 2025 14:53
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team February 13, 2025 14:53
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) February 13, 2025 14:54
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@5519a01). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nents/instance-wizard/instance-wizard.component.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11544   +/-   ##
===================================================
  Coverage                    ?   82.99%           
===================================================
  Files                       ?     1653           
  Lines                       ?    58971           
  Branches                    ?     6242           
===================================================
  Hits                        ?    48943           
  Misses                      ?    10028           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 8726750 into stable/fangtooth Feb 13, 2025
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133963-25.04-RC.1 branch February 13, 2025 15:24
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants