Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134042 / 25.04-RC.1 / Add a warning when failover is unhealthy to RebootRequiredDialogComponent (by AlexKarpov98) #11554

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x f87c9367ebac2ae566f0c3a57384204a39b377a6
git cherry-pick -x 12fa75c8557819f7d2196269557e1437d9a1e1d5
git cherry-pick -x de35632f8674dfc3bf63ccf1240420c2597654e2
git cherry-pick -x 5ed8e54b4e1a590a47ddb3712d27f02c0aeb98ce

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 2ca4b1d275d562c372bebd444f6027bab168f7a4

Testing: see ticket.

I worked with mocked data.

We need to have such data in store:

export const selectHaStatus = createSelector(
  selectHaInfoState,
  (state) => ({
    ...state?.haStatus,
    reasons: [FailoverDisabledReason.MismatchDisks],
  }),
);

export const selectCanFailover = createSelector(
  selectHaInfoState,
  () => false,
);

Example:
Screenshot 2025-02-12 at 08 46 42

Original PR: #11543
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134042

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review February 13, 2025 15:23
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner February 13, 2025 15:23
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team February 13, 2025 15:23
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) February 13, 2025 15:24
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/fangtooth@db3209d). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11554   +/-   ##
===================================================
  Coverage                    ?   82.99%           
===================================================
  Files                       ?     1653           
  Lines                       ?    58967           
  Branches                    ?     6237           
===================================================
  Hits                        ?    48942           
  Misses                      ?    10025           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 0f33232 into stable/fangtooth Feb 13, 2025
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-134042-25.04-RC.1 branch February 13, 2025 15:46
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants