Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133897 / 25.04-RC.1 / Add disk reporting temps (by bvasilenko) #11563

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

bugclerk
Copy link
Contributor

Testing:

At the Reporting > Disks screen,

Expected result: the disk temperature data displayed correctly

Original PR: #11542
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133897

(cherry picked from commit 164ab28)
@bugclerk bugclerk requested a review from a team as a code owner February 15, 2025 06:40
@bugclerk bugclerk requested review from bvasilenko and removed request for a team February 15, 2025 06:40
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backported

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/fangtooth@323e1ff). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11563   +/-   ##
===================================================
  Coverage                    ?   82.99%           
===================================================
  Files                       ?     1653           
  Lines                       ?    58982           
  Branches                    ?     6244           
===================================================
  Hits                        ?    48954           
  Misses                      ?    10028           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvasilenko bvasilenko merged commit 084f8c9 into stable/fangtooth Feb 17, 2025
9 checks passed
@bvasilenko bvasilenko deleted the NAS-133897-25.04-RC.1 branch February 17, 2025 05:05
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants