Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131881 / 25.04-RC.1 / GUI restrictions/issues present when accessing TrueNAS in Mobile display size (by AlexKarpov98) #11565

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

bugclerk
Copy link
Contributor

Testing: see ticket.

Check each 12 steps provided in the ticket.

Note my comment:

this (9) issue deserves a separate ticket.

Drag and drop selection for manual disk selection is not possible in Mobile mode. No method in place to perform this.

Original PR: #11550
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131881

@bugclerk bugclerk requested a review from a team as a code owner February 15, 2025 08:28
@bugclerk bugclerk requested review from undsoft and removed request for a team February 15, 2025 08:28
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) February 15, 2025 08:33
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@323e1ff). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...dataset-management/dataset-management.component.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11565   +/-   ##
===================================================
  Coverage                    ?   82.99%           
===================================================
  Files                       ?     1653           
  Lines                       ?    58979           
  Branches                    ?     6244           
===================================================
  Hits                        ?    48951           
  Misses                      ?    10028           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 2aa86ff into stable/fangtooth Feb 15, 2025
8 of 9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131881-25.04-RC.1 branch February 15, 2025 08:53
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants