Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133904 / 25.04.0 / Editing the Network Widget saved the values to the other portion of the widget (by bvasilenko) #11640

Open
wants to merge 1 commit into
base: stable/fangtooth
Choose a base branch
from

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Feb 28, 2025

Testing:

Please see the ticket for replication steps and expected result.

Original PR: #11524
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133904

@bvasilenko bvasilenko marked this pull request as ready for review March 11, 2025 12:39
@bvasilenko bvasilenko requested a review from a team as a code owner March 11, 2025 12:39
@bvasilenko bvasilenko requested review from AlexKarpov98 and removed request for a team March 11, 2025 12:39
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@0d35b58). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ttings/widget-arbitrary-text-settings.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11640   +/-   ##
===================================================
  Coverage                    ?   83.12%           
===================================================
  Files                       ?     1659           
  Lines                       ?    59305           
  Branches                    ?     6278           
===================================================
  Hits                        ?    49297           
  Misses                      ?    10008           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants