Auto-add missing snapshots (#855)

Create new snapshots from https://github.com/trunk-io/plugins/actions/runs/10629134024 --------- Co-authored-by: TylerJang27 <[email protected]> Co-authored-by: Tyler Jang <[email protected]>
trunk-io · Aug 30, 2024 · 7c99365 · 7c99365
1 parent 1d8745c
commit 7c99365
Show file tree

Hide file tree

Showing 7 changed files with 983 additions and 433 deletions.
diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml
@@ -17,7 +17,7 @@ plugins:
 
     - id: configs
       uri: https://github.com/trunk-io/configs
-      ref: v1.0.7
+      ref: v1.0.8
 
 lint:
   files:
@@ -46,7 +46,6 @@ lint:
   disabled:
     - pylint # pylint diagnostics are too strict
     - semgrep
-    - trivy # investigating issues with shared cachedir
 
   ignore:
     - linters: [ALL]

diff --git a/linters/buildifier/test_data/buildifier_v7.3.1_basic_check.check.shot b/linters/buildifier/test_data/buildifier_v7.3.1_basic_check.check.shot
@@ -0,0 +1,135 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+// trunk-upgrade-validation:RELEASE
+
+exports[`Testing linter buildifier test basic_check 1`] = `
+{
+  "issues": [
+    {
+      "code": "module-docstring",
+      "column": "1",
+      "file": "test_data/basic.bzl",
+      "issueClass": "ISSUE_CLASS_EXISTING",
+      "issueUrl": "https://github.com/bazelbuild/buildtools/blob/main/WARNINGS.md#module-docstring",
+      "level": "LEVEL_HIGH",
+      "line": "1",
+      "linter": "buildifier",
+      "message": "The file has no module docstring.
+A module docstring is a string literal (not a comment) which should be the first statement of a file (it may follow comment lines).",
+      "targetType": "starlark",
+    },
+    {
+      "code": "load",
+      "column": "26",
+      "file": "test_data/basic.bzl",
+      "issueClass": "ISSUE_CLASS_EXISTING",
+      "issueUrl": "https://github.com/bazelbuild/buildtools/blob/main/WARNINGS.md#load",
+      "level": "LEVEL_HIGH",
+      "line": "1",
+      "linter": "buildifier",
+      "message": "Loaded symbol "a" is unused. Please remove it.
+To disable the warning, add '@unused' in a comment.
+If you want to re-export a symbol, use the following pattern:
+
+    load(..., _a = "a", ...)
+    a = _a",
+      "targetType": "starlark",
+    },
+    {
+      "code": "load",
+      "column": "26",
+      "file": "test_data/basic.bzl",
+      "issueClass": "ISSUE_CLASS_EXISTING",
+      "issueUrl": "https://github.com/bazelbuild/buildtools/blob/main/WARNINGS.md#load",
+      "level": "LEVEL_HIGH",
+      "line": "2",
+      "linter": "buildifier",
+      "message": "Loaded symbol "b" is unused. Please remove it.
+To disable the warning, add '@unused' in a comment.
+If you want to re-export a symbol, use the following pattern:
+
+    load(..., _b = "b", ...)
+    b = _b",
+      "targetType": "starlark",
+    },
+  ],
+  "lintActions": [
+    {
+      "command": "fix",
+      "fileGroupName": "bazel-build",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/add_tables.BUILD",
+      ],
+      "verb": "TRUNK_VERB_FMT",
+    },
+    {
+      "command": "fix",
+      "fileGroupName": "starlark",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/basic.bzl",
+      ],
+      "verb": "TRUNK_VERB_FMT",
+    },
+    {
+      "command": "warn",
+      "fileGroupName": "bazel-build",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/add_tables.BUILD",
+      ],
+      "verb": "TRUNK_VERB_CHECK",
+    },
+    {
+      "command": "warn",
+      "fileGroupName": "starlark",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/basic.bzl",
+      ],
+      "verb": "TRUNK_VERB_CHECK",
+    },
+    {
+      "command": "warn",
+      "fileGroupName": "bazel-build",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/add_tables.BUILD",
+      ],
+      "upstream": true,
+      "verb": "TRUNK_VERB_CHECK",
+    },
+    {
+      "command": "warn",
+      "fileGroupName": "starlark",
+      "linter": "buildifier",
+      "paths": [
+        "test_data/basic.bzl",
+      ],
+      "upstream": true,
+      "verb": "TRUNK_VERB_CHECK",
+    },
+  ],
+  "taskFailures": [],
+  "unformattedFiles": [
+    {
+      "column": "1",
+      "file": "test_data/add_tables.BUILD",
+      "issueClass": "ISSUE_CLASS_UNFORMATTED",
+      "level": "LEVEL_HIGH",
+      "line": "1",
+      "linter": "buildifier",
+      "message": "Incorrect formatting, autoformat by running 'trunk fmt'",
+    },
+    {
+      "column": "1",
+      "file": "test_data/basic.bzl",
+      "issueClass": "ISSUE_CLASS_UNFORMATTED",
+      "level": "LEVEL_HIGH",
+      "line": "1",
+      "linter": "buildifier",
+      "message": "Incorrect formatting, autoformat by running 'trunk fmt'",
+    },
+  ],
+}
+`;
diff --git a/linters/buildifier/test_data/buildifier_v7.3.1_no_config.test_data.add_tables.BUILD.fmt.shot b/linters/buildifier/test_data/buildifier_v7.3.1_no_config.test_data.add_tables.BUILD.fmt.shot
@@ -0,0 +1,36 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+// trunk-upgrade-validation:RELEASE
+
+exports[`Testing formatter buildifier test no_config 1`] = `
+"foo_macro(
+    fizz = [
+        ":lib2",
+        ":lib1",
+    ],
+)
+
+filegroup(
+    name = "files",
+    srcs = glob(["**"]),
+)
+
+sh_library(
+    name = "lib1",
+    srcs = ["src1.sh"],
+)
+
+sh_library(
+    name = "lib2",
+    srcs = ["src1.sh"],
+)
+
+sh_binary(
+    name = "foo",
+    srcs = ["foo.sh"],
+    deps = [
+        ":lib1",
+        ":lib2",
+    ],
+)
+"
+`;
diff --git a/linters/buildifier/test_data/buildifier_v7.3.1_no_config.test_data.basic.bzl.fmt.shot b/linters/buildifier/test_data/buildifier_v7.3.1_no_config.test_data.basic.bzl.fmt.shot
@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+// trunk-upgrade-validation:RELEASE
+
+exports[`Testing formatter buildifier test no_config 1`] = `
+"# Misformatted file
+def eponymous_name():
+    name = native.package_name()
+
+    return name[name.rfind("/") + 1:]
+"
+`;
diff --git a/...rs/buildifier/test_data/buildifier_v7.3.1_with_config.test_data.add_tables.BUILD.fmt.shot b/...rs/buildifier/test_data/buildifier_v7.3.1_with_config.test_data.add_tables.BUILD.fmt.shot
@@ -0,0 +1,36 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+// trunk-upgrade-validation:RELEASE
+
+exports[`Testing formatter buildifier test with_config 1`] = `
+"foo_macro(
+    fizz = [
+        ":lib1",
+        ":lib2",
+    ],
+)
+
+filegroup(
+    name = "files",
+    srcs = glob(["**"]),
+)
+
+sh_library(
+    name = "lib1",
+    srcs = ["src1.sh"],
+)
+
+sh_library(
+    name = "lib2",
+    srcs = ["src1.sh"],
+)
+
+sh_binary(
+    name = "foo",
+    srcs = ["foo.sh"],
+    deps = [
+        ":lib1",
+        ":lib2",
+    ],
+)
+"
+`;