normalize URL properly

trunk-io · Jul 24, 2024 · f4ff3e7 · f4ff3e7
1 parent b6ab3be
commit f4ff3e7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/linters/markdownlint/test_data/markdownlint_v0.33.0_basic.check.shot b/linters/markdownlint/test_data/markdownlint_v0.33.0_basic.check.shot
@@ -7,7 +7,7 @@ exports[`Testing linter markdownlint test basic 1`] = `
       "code": "MD025",
       "file": "test_data/basic.in.md",
       "issueClass": "ISSUE_CLASS_EXISTING",
-      "issueUrl": "https://github.com/DavidAnson/markdownlint/blob/v0.27.0/doc/md025.md",
+      "issueUrl": "https://github.com/DavidAnson/markdownlint/blob/vx.x.x/doc/md025.md",
       "level": "LEVEL_LOW",
       "line": "3",
       "linter": "markdownlint",

diff --git a/tests/types/index.ts b/tests/types/index.ts
@@ -75,7 +75,7 @@ export interface FileIssue {
   targetPath?: string;
   autofixOptions?: Autofix[];
   ranges?: any[];
-  issueUrl: string;
+  issueUrl?: string;
   belowThreshold?: boolean;
 }
 

diff --git a/tests/utils/landing_state.ts b/tests/utils/landing_state.ts
@@ -87,10 +87,14 @@ const normalizeRange = ({ filePath: _filePath = undefined, ...rest }) => ({
   ...rest,
 });
 
+const normalizeIssueUrl = (issueUrl: string) =>
+  issueUrl.replace(/markdownlint\/blob\/v[0-9.]+\//gm, "markdownlint/blob/vx.x.x/").trim();
+
 const normalizeIssues = ({
   message: _message,
   targetPath: _targetPath,
   file: _file,
+  issueUrl: _issueUrl,
   autofixOptions: _autofixOptions = [],
   ranges: _ranges,
   ...rest
@@ -107,6 +111,9 @@ const normalizeIssues = ({
   if (_autofixOptions.length > 0) {
     ret.autofixOptions = _autofixOptions.map(normalizeAutofix);
   }
+  if (_issueUrl) {
+    ret.issueUrl = normalizeIssueUrl(_issueUrl);
+  }
   return ret;
 };