Add goreleaser tool. #729
Merged
Add goreleaser tool. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 20m total CI duration on this PR
|
TylerJang27
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Hi! Thanks for the PR! Could you make the additional changes to add testing:
- Create a
tools/goreleaser/goreleaser.test.tswith contents:
import { toolInstallTest } from "tests";
toolInstallTest({
toolName: "goreleaser",
toolVersion: "1.25.1",
});- You can run
npm ci; npm test goreleaserto verify it works. - Run
trunk fmt tools/goreleaserto match our formatting standards
|
@TylerJang27 Done and Done. |
TylerJang27
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add goreleaser tool using the go runtime to build & install it.