Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier support for postcss #740

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add prettier support for postcss #740

merged 1 commit into from
Apr 11, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Apr 11, 2024

Tested manually on a toy example that prettier formats these correctly. Using postcss extension as reference. Fixes #738

Copy link

trunk-io bot commented Apr 11, 2024

⏱️ 43m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 21m 🟩
Linter Tests macOS 15m 🟩
Windows Linter Tests 3m 🟩
Trunk Check runner [linux] 1m 🟩
CodeQL-Build 1m 🟩
Repo Tests / Plugin Tests 51s 🟩
Detect changed files 3s 🟩
Aggregate Test Results 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review April 11, 2024 18:34
@@ -412,6 +412,12 @@ lint:
extensions:
- png

- name: postcss
extensions:
# TODO(Tyler): Do we want to include css here as well?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think so? we have a css filetype already?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, although there's an intersection. It may be more ergonomic to include it here with an inherits, but probably best to keep separate for extensibility

@TylerJang27 TylerJang27 merged commit 1a3d5aa into main Apr 11, 2024
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/postcss branch April 11, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Request: add 'postcss' file support to prettier plugin
2 participants