Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload eslint validated versions #794

Merged
merged 1 commit into from
May 31, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented May 30, 2024

This is a temporary mechanism to avoid sending new, 9.x validated versions for eslint to LUV. That way, we can make a plugins release that has the eslint9 support, and users on older CLI versions will have some time to upgrade before we start OOTB recommending newest eslint. See #735 (comment)

Intended to be reverted ~1 week after next plugins release

Copy link

trunk-io bot commented May 30, 2024

⏱️ 2m total CI duration on this PR

Job Cumulative Duration Recent Runs
CodeQL-Build 1m 🟩
Trunk Check runner [linux] 36s 🟩
Repo Tests / Plugin Tests 31s 🟩
Detect changed files 4s 🟩
Aggregate Test Results 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 requested a review from det May 30, 2024 18:24
@TylerJang27 TylerJang27 marked this pull request as ready for review May 30, 2024 18:24
@TylerJang27 TylerJang27 merged commit fc7928c into main May 31, 2024
13 checks passed
@TylerJang27 TylerJang27 deleted the tyler/disable-eslint-from-luv branch May 31, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants