Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definition for trunk-toolbox to include latest support for neveredit rule #859

Merged
merged 13 commits into from
Sep 3, 2024
Merged

Update definition for trunk-toolbox to include latest support for neveredit rule #859

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a666e5c
EliSchleifer Feb 27, 2024
a1d8bf1
EliSchleifer Feb 27, 2024
945338c
EliSchleifer Feb 27, 2024
fa4f4af
EliSchleifer Feb 27, 2024
500dd89
EliSchleifer Aug 30, 2024
7b263ad
update toolbox to support hold-the-line
EliSchleifer Aug 30, 2024
32ebead
update toolbox version
EliSchleifer Aug 30, 2024
f6dedf0
EliSchleifer Aug 30, 2024
41f0dbb
Merge branch 'main' into eli/update-toolbox
EliSchleifer Aug 30, 2024
4d2bf43
Merge branch 'main' into eli/update-toolbox
EliSchleifer Sep 3, 2024
28c1e76
add new snapshot
EliSchleifer Sep 3, 2024
69127a1
Merge branch 'main' into eli/update-toolbox
EliSchleifer Sep 3, 2024
a48b665
Merge remote-tracking branch 'origin/eli/update-toolbox' into eli/upd…
EliSchleifer Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .trunk/trunk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ lint:
# enabled linters inherited from github.com/trunk-io/configs plugin
- definition-checker
- [email protected]
- [email protected]
disabled:
- pylint # pylint diagnostics are too strict
- semgrep
Expand Down
17 changes: 13 additions & 4 deletions linters/trunk-toolbox/plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 0.1

downloads:
- name: trunk-toolbox
version: 0.3.1
version: 0.4.1
downloads:
- os:
linux: unknown-linux-gnu
Expand All @@ -17,21 +17,30 @@ tools:
- name: trunk-toolbox
download: trunk-toolbox
shims: [trunk-toolbox]
known_good_version: 0.3.1
known_good_version: 0.4.1
lint:
definitions:
- name: trunk-toolbox
description: repository level linting tools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: repository level linting tools
description: Repository-level linting tools

main_tool: trunk-toolbox
files: [ALL]
description: Collection of universal linting tools
commands:
- name: lint
run: trunk-toolbox --upstream=${upstream-ref} --results=${tmpfile} ${target}
version: ">=0.4.1"
run:
trunk-toolbox --upstream=${upstream-ref} --cache-dir=${cachedir} --results=${tmpfile}
${target}
output: sarif
batch: true
success_codes: [0]
read_output_from: tmp_file
- name: lint
run: trunk-toolbox --upstream=${upstream-ref} --results=${tmpfile} ${target}
output: sarif
batch: true
success_codes: [0]
disable_upstream: true
read_output_from: tmp_file
suggest_if: never
version_command:
parse_regex: ${semver}
Expand Down
Loading