Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for markdownlint-cli2 #879

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Add support for markdownlint-cli2 #879

merged 7 commits into from
Sep 27, 2024

Conversation

det
Copy link
Contributor

@det det commented Sep 26, 2024

This pull request introduces a new linter, markdownlint-cli2, and updates the documentation and configuration files accordingly. The most important changes include adding the new linter to the README.md, creating configuration and test files for markdownlint-cli2, and updating existing linter configurations.

Introduction of markdownlint-cli2:

  • Configuration and Test Files:
    • Created a basic test for markdownlint-cli2 in linters/markdownlint-cli2/markdownlint.test.ts.
    • Defined the markdownlint-cli2 tool and its configurations in linters/markdownlint-cli2/plugin.yaml.
    • Added a JSON configuration file for markdownlint-cli2 in linters/markdownlint-cli2/test_data/.markdownlint-cli2.jsonc.
    • Provided test data and expected output for markdownlint-cli2 in linters/markdownlint-cli2/test_data/basic.in.md and linters/markdownlint-cli2/test_data/markdownlint_cli2_v0.14.0_basic.check.shot. [1] [2]

Documentation Updates:

  • README.md:
    • Updated the Markdown linters list to include markdownlint-cli2 in README.md.

Removal of Old Configurations:

  • Old Linter Configurations:
    • Removed outdated markdownlint-cli2 configurations from linters/markdownlint/plugin.yaml.

Copy link

trunk-io bot commented Sep 26, 2024

⏱️ 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 7m 🟩🟩🟩
Windows Linter Tests 7m 🟩🟩🟩
Trunk Check runner [linux] 5m 🟩🟩🟩
Linter Tests macOS 5m 🟩🟩🟩
CodeQL-Build 4m 🟩🟩🟩
Repo Tests / Plugin Tests 2m 🟩🟩🟩
Detect changed files 22s 🟩🟩🟩
Aggregate Test Results 5s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@det det requested a review from TylerJang27 September 26, 2024 19:32
@det det marked this pull request as ready for review September 26, 2024 19:32
Copy link

trunk-staging-io bot commented Sep 26, 2024

✅ 8 passed ⋅ (learn more)

settingsdocs ⋅ learn more about trunk.io

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One callout

| Kotlin | [detekt], [ktlint] |
| Kubernetes | [kube-linter] |
| Lua | [stylua] |
| Markdown | [deno], [markdownlint], [markdownlint-cli2], [markdown-link-check], [markdown-table-prettify], [prettier], [remark-lint] |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link for this below the table

@det det merged commit 512ca70 into main Sep 27, 2024
14 checks passed
@det det deleted the det/md2 branch September 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants