Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuda source file types #942

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

NellyWhads
Copy link
Contributor

Replicates the file type structure from C files to Cuda files.

  • Source file convention remains *.cu
  • Header file convention is added to include *.cuh files

The community-adopted *.cuh convention is exemplified in many large-scale public repositories, including torch.

Copy link

trunk-io bot commented Dec 27, 2024

⏱️ 1h 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 42m 🟩🟩
Linter Tests macOS 23m 🟩
CodeQL-Build 3m 🟩🟩
Trunk Check runner [linux] 2m 🟩🟩
Repo Tests / Plugin Tests 1m 🟩🟩
Detect changed files 16s 🟩🟩
Aggregate Test Results 1s 🟥🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR!

@NellyWhads
Copy link
Contributor Author

(rebased but it may have broken something with the CI trigger - apologies)

@TylerJang27 TylerJang27 merged commit 8874a8d into trunk-io:main Dec 30, 2024
13 checks passed
@NellyWhads NellyWhads deleted the cuda_headers branch December 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants