fix: install latest node if setup-node fails #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxlijin
reviewed
Sep 13, 2023
.github/workflows/repo_tests.yaml
Outdated
Comment on lines
108
to
109
| - repo: trunk-io/trunk-action | ||
| ref: main |
There was a problem hiding this comment.
can we somehow verify that the first pass of setup-node here will fail? or choose another repo where that's guaranteed?
i can totally see us pinning a valid engine in trunk-action, which is why this test makes me nervous
setup-env/action.yaml
Outdated
Comment on lines
93
to
95
| cat >>$GITHUB_ENV <<EOF | ||
| FAILED_NODE_INSTALL=true | ||
| EOF |
There was a problem hiding this comment.
Suggested change
| cat >>$GITHUB_ENV <<EOF | |
| FAILED_NODE_INSTALL=true | |
| EOF | |
| echo "FAILED_NODE_INSTALL=true" >>$GITHUB_ENV |
sxlijin
approved these changes
Sep 13, 2023
puzzler7
deleted the
maverick/trunk-8777-install-reasonable-default-node-version-if-setup-node-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues if the setup-node action fails to install, and then installs latest node if there is no node version installed. Judging by this website showing note compatibilities, node is almost entirely backwards compatible, which is why I went with the latest version rather than e.g. node 20.
Additionally, adds a node version to the package.json so that this PR can merge - the v1 action version still chokes when not finding the node version.
This is tested by adding the trunk-action repo to the repo tests, which does not have a node version in main. However, the runners have node installed, so the action doesn't attempt to install a default version - I'm not sure if there's a better way to test that/if it's worth it.