Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test skip check 3 #223

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
group: ${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions: read-all
#permissions: read-all

Check failure on line 7 in .github/workflows/pr.yaml

View check run for this annotation

Trunk-Staging.io / Trunk Check

checkov(CKV2_GHA_1)

[new] Ensure top-level permissions are not set to write-all

Check failure on line 7 in .github/workflows/pr.yaml

View workflow job for this annotation

GitHub Actions / Trunk Check

checkov(CKV2_GHA_1)

[new] Ensure top-level permissions are not set to write-all

jobs:
trunk_check:
Expand All @@ -18,7 +18,7 @@
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0

- name: Trunk Check
uses: ./ # external users, use: trunk-io/trunk-action@v1
uses: trunk-io/trunk-action@97ecd21fe6c743bf7a606791584b683a7995c70e

action_tests:
name: Action tests
Expand Down
4 changes: 2 additions & 2 deletions .trunk/trunk.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
version: 0.1

cli:
version: 1.19.0
version: 1.18.1

plugins:
sources:
- id: trunk
ref: v1.4.2
ref: v1.3.0
uri: https://github.com/trunk-io/plugins
- id: configs
ref: v1.0.1
Expand Down
1 change: 1 addition & 0 deletions new.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cd $1

Check failure on line 1 in new.sh

View check run for this annotation

Trunk-Staging.io / Trunk Check

shellcheck(SC2148)

[new] Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

Check warning on line 1 in new.sh

View check run for this annotation

Trunk-Staging.io / Trunk Check

shellcheck(SC2164)

[new] Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Check notice on line 1 in new.sh

View check run for this annotation

Trunk-Staging.io / Trunk Check

shellcheck(SC2086)

[new] Double quote to prevent globbing and word splitting.

Check failure on line 1 in new.sh

View workflow job for this annotation

GitHub Actions / Trunk Check

shellcheck(SC2148)

[new] Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

Check warning on line 1 in new.sh

View workflow job for this annotation

GitHub Actions / Trunk Check

shellcheck(SC2164)

[new] Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Check notice on line 1 in new.sh

View workflow job for this annotation

GitHub Actions / Trunk Check

shellcheck(SC2086)

[new] Double quote to prevent globbing and word splitting.
Loading