Skip to content

Commit

Permalink
Extend the recent work to solidify the FS watcher
Browse files Browse the repository at this point in the history
Ultimately, deeper investigation has revealed that std::fs::copy will
generate modification events on the source file (the file being copied)
on some platforms. This has proven to be a source of difficulty for the
FS watcher, and has lead to infinite build loops, despite the fact that
none of the files / directories being watched were actually changed.

Here we implement a post-build cooldown interval of 1s. This ensures
that in very fast builds, we do not end up receiving a modification
event due to std::fs::copy (from the copy source).

Moreover, any FS events which have accumulated during the 1s cooldown
will be purged. Altogether this will hopefully fully address the
recursive build issue, and will hopefully not disrupt the development
workflow.

Also, update deps, changelog and a few README items.
  • Loading branch information
thedodd committed Aug 22, 2023
1 parent 5ffcb35 commit efff459
Show file tree
Hide file tree
Showing 5 changed files with 357 additions and 422 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe

## Unreleased

## 0.17.4
### added
- Multiple PRs have been landed in attempts to address the recursive / infinite build cycle which can be triggered under some conditions. Shoutout to @ctron for their work in driving this resolution forward.

## 0.17.3
### added
- Add `inject_scripts` option to build configuration to allow toggle of injecting the modulepreload and scripts rendered in the final html.
Expand Down
Loading

0 comments on commit efff459

Please sign in to comment.