Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo fmt #37

Closed

Conversation

sosthene-nitrokey
Copy link
Contributor

This PR runs cargo-fmt on trussed.

This creates conflicts with other branches but they can be solved with some bits of git magic. There is a rebased branch for #29 at here

To be used with git blame --ignore-revs-file .git-blame-ignore-revs
This also applies to Github's blame view https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
@sosthene-nitrokey
Copy link
Contributor Author

Any updates on merging this? @nickray you mentioned not wanting this to pollute git blame so I added a .git-blame-ignore-revs which is automatically picked up git github's blame view. It can be used with git blame --ignore-revs-file=.git-blame-ignore-revs

@szszszsz szszszsz requested a review from nickray September 5, 2022 09:01
@szszszsz
Copy link

szszszsz commented Sep 5, 2022

@nickray
For the review you can use difftastic for the AST aware diff:

@nickray nickray mentioned this pull request Sep 11, 2022
@nickray
Copy link
Member

nickray commented Sep 11, 2022

Thank you for the pointer to .git-blame-ignore-revs, merged #42 instead. Checked that the existing PRs simply drop the commits here.

@nickray nickray closed this Sep 11, 2022
sosthene-nitrokey pushed a commit to sosthene-nitrokey/trussed that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants