Skip to content

Typing Issues #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Typing Issues #104

merged 1 commit into from
Dec 5, 2022

Conversation

chtakahashi
Copy link
Contributor

The most recent minor version change introduces the following error:

│     ├────────────────
│     │ rule.value is object with 4 attributes
│
│ This object does not have an attribute named "search_string".

The issue is that the object structure specified under the dynamic "rule" is missing the search_string field.

Also addressed the fact that the variable specification of search_string is a string (and the string is used in string comparisons against "") but the default value is null.

@chtakahashi chtakahashi merged commit 4fbae01 into main Dec 5, 2022
@chtakahashi chtakahashi deleted the fix-filtered-rule-structure branch December 5, 2022 17:15
@rpdelaney
Copy link
Contributor

v2.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esacteksab esacteksab esacteksab approved these changes

@rpdelaney rpdelaney Awaiting requested review from rpdelaney

@ildeleaf ildeleaf Awaiting requested review from ildeleaf

@marycrawford marycrawford Awaiting requested review from marycrawford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chtakahashi @rpdelaney @esacteksab