systemd: use Type=simple and no fork to avoid PIDFile race #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just stretches the race condition a little bit. A better solution is to just drop the For example on Arch Linux it's done this way: https://github.com/archlinux/svntogit-community/blob/packages/opendkim/trunk/opendkim.service |
|
@ghen2 fair play. We can instead use type=simple and opendkim -f so it doesn't fork. Then we don't care about the PIDFIle at all either. |
Red Hat Bugilla #2056209
mdomsch
force-pushed
the
systemd-delay-pid-check
branch
from
4a93a7d
to
d74d5f9
Compare
mdomsch
changed the title
ghen2
approved these changes
Feb 24, 2022
This is a long-running process that once started by systemd should stay running forever. In the event of a fatal error and unclean exit, we want systemd to restart the program. We use on-abnormal because there are valid nonzero exit codes (EX_USAGE, EX_OSERR) which the program can properly return indicating a configuration or command line error, or inability to allocate memory early on. In these events, restarting would be inappropriate, but on-failure would try anyhow.
|
Looks good! I have submitted a similar patch to Debian, that also enables various hardening options: https://salsa.debian.org/debian/opendkim/-/merge_requests/3 I'll open a PR here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Red Hat BZ#2056209