Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenSSL 3 #162

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

glts
Copy link

@glts glts commented Dec 28, 2022

The proposed change upgrades OpenSSL to version 3.

The change is not too big, it looks sensible to me, it is backwards compatible, and the test suite passes. I have done successful manual testing using opendkim-testmsg for both signing and verifying, using signature algorithms rsa-sha256 and ed25519-sha256. configure.ac hasn’t been updated yet. Feedback welcome.

@thegushi
Copy link
Collaborator

I notice new include files. What happens if this is built on a system that doesn't yet support openssl 3?

@glts glts marked this pull request as draft December 28, 2022 14:35
@glts
Copy link
Author

glts commented Dec 28, 2022

The new include files already existed in OpenSSL < 3, but there needs to be the appropriate feature detection in configure.ac. I’m marking this pull request as in draft status.

@ghen2
Copy link

ghen2 commented Dec 29, 2022

See also #135.

@glts
Copy link
Author

glts commented Dec 29, 2022

I cannot spend time investigating compatibility with legacy OpenSSL version 1.1.1 (EOL September 2023), so removing the draft status and moving on for now.

@glts glts marked this pull request as ready for review December 29, 2022 17:22
@glts
Copy link
Author

glts commented Jan 2, 2023

Rebased, and added a tiny commit which restores compatibility with OpenSSL version 1.1.1.

The pull request as now proposed simply moves to the non-deprecated APIs in OpenSSL 3, but all APIs were already present in OpenSSL 1.1.1.

@thegushi
Copy link
Collaborator

thegushi commented Jan 6, 2023

I'm likely to merge this, but which openSSL 3 system did you test it on?

@glts
Copy link
Author

glts commented Jan 6, 2023

@thegushi I used Ubuntu 22.04 LTS with the packaged OpenSSL 3.0.2.

It’s good that for once a pull request is not received with total radio
silence. However, I have four other pull requests open in this project,
and I would prefer if you could merge them first. They are small,
straightforward, benign, and they address real problems. Also they have
been widely tested as they are included in Debian/Ubuntu. Would it be
too much to ask to look through them and press that merge button?

@andreasschulze
Copy link

I'm using this patchset (with openssl-3.1.0). RSA and ED25519 signing as well as validation work as expected.
Not tested (because not used here): opendkim-genzone ...

futatuki added a commit to futatuki/OpenDKIM that referenced this pull request Feb 25, 2024
futatuki added a commit to futatuki/OpenDKIM that referenced this pull request Mar 24, 2024
futatuki added a commit to futatuki/OpenDKIM that referenced this pull request Apr 26, 2024
futatuki added a commit to futatuki/OpenDKIM that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants