Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Updated OpenRouter models #335

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jun 10, 2024

Created by Github Actions

Summary by CodeRabbit

  • New Features

    • Added support for new models: Dolphin292Mixtral8X22b, Qwen272BInstruct, OpenChat368B, and Phi3MediumInstruct.
  • Enhancements

    • Updated parameters for existing model Yi6BBase to improve performance.

Copy link
Contributor

coderabbitai bot commented Jun 10, 2024

Walkthrough

The recent updates introduce new model identifiers and their respective entries in the Models dictionary within the LangChain.Providers.OpenRouter namespace. Specifically, four new model identifiers—Dolphin292Mixtral8X22b, Qwen272BInstruct, OpenChat368B, and Phi3MediumInstruct—have been added, along with detailed descriptions and initialization parameters. Additionally, some existing model entries have been updated with new parameter values to enhance functionality.

Changes

Files Change Summary
src/Providers/OpenRouter/src/OpenRouterModelIds.cs Added new model identifiers: Dolphin292Mixtral8X22b, Qwen272BInstruct, OpenChat368B, and Phi3MediumInstruct with descriptions.
src/Providers/OpenRouter/src/OpenRouterModelProvider.cs Added new entries to the Models dictionary for the new model identifiers and updated existing entries with new parameters.

Poem

In the land of code, where models roam,
New entries join the digital home.
Dolphin, Qwen, and OpenChat,
Phi3 too, imagine that!
Parameters set, they shine so bright,
In LangChain's world, they bring delight.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot enabled auto-merge June 10, 2024 06:30
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (5)
src/Providers/OpenRouter/src/OpenRouterModelProvider.cs (1)

12-21: Ensure consistency in parameter documentation for new model entries.

It would enhance maintainability and clarity if the parameters for the new ChatModels instances (Dolphin292Mixtral8X22b, Qwen272BInstruct, OpenChat368B, Phi3MediumInstruct) included comments describing their purpose, similar to existing entries in the codebase.

src/Providers/OpenRouter/src/Predefined/AllModels.cs (4)

3-5: Ensure the constructor's XML documentation is complete and accurate.

Consider adding a more detailed description in the XML documentation for Dolphin292Mixtral8X22bModel to explain the specific role or characteristics of this model.


8-10: Ensure the constructor's XML documentation is complete and accurate.

Consider adding a more detailed description in the XML documentation for Qwen272BInstructModel to explain the specific role or characteristics of this model.


13-15: Ensure the constructor's XML documentation is complete and accurate.

Consider adding a more detailed description in the XML documentation for OpenChat368BModel to explain the specific role or characteristics of this model.


48-50: Ensure the constructor's XML documentation is complete and accurate.

Consider adding a more detailed description in the XML documentation for Phi3MediumInstructModel to explain the specific role or characteristics of this model.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6239436 and 6649ec2.

Files selected for processing (3)
  • src/Providers/OpenRouter/src/OpenRouterModelIds.cs (2 hunks)
  • src/Providers/OpenRouter/src/OpenRouterModelProvider.cs (3 hunks)
  • src/Providers/OpenRouter/src/Predefined/AllModels.cs (1 hunks)
Files not summarized due to errors (1)
  • src/Providers/OpenRouter/src/Predefined/AllModels.cs: Error: Message exceeds token limit
Additional comments not posted (5)
src/Providers/OpenRouter/src/OpenRouterModelProvider.cs (1)

112-112: Verify the updated parameters for Yi6BBase are correct.

src/Providers/OpenRouter/src/OpenRouterModelIds.cs (4)

9-16: Ensure the detailed description for Dolphin292Mixtral8X22b is accurate and aligns with the model's capabilities.

Verification successful

The search results indicate that the description for Dolphin292Mixtral8X22b in OpenRouterModelIds.cs is consistent with its usage and references in the codebase. However, there are no external references or additional documentation found that could further validate the detailed description provided.

  • src/Providers/OpenRouter/src/OpenRouterModelIds.cs: Contains the description and the enum entry for Dolphin292Mixtral8X22b.
  • src/Providers/OpenRouter/src/OpenRouterModelProvider.cs: Maps the model ID to its corresponding chat model.
  • src/Providers/OpenRouter/src/Predefined/AllModels.cs: Contains a class and an inheritdoc reference for Dolphin292Mixtral8X22b.

Given the absence of external documentation or additional context, the description appears to be self-contained and accurate based on the available code.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the accuracy of the description for Dolphin292Mixtral8X22b.

# Test: Search for external references to validate the description.
rg --type markdown $'Dolphin 2.9' README.md

Length of output: 44



Script:

#!/bin/bash
# Description: Verify the accuracy of the description for Dolphin292Mixtral8X22b.

# Test: Search for references to Dolphin 2.9 and Dolphin292Mixtral8X22b across the entire repository.
rg 'Dolphin 2.9'
rg 'Dolphin292Mixtral8X22b'

Length of output: 932


26-33: Check the performance claims of OpenChat368B against benchmark results to ensure accuracy.


75-79: Validate the release information and performance metrics for Phi3MediumInstruct with the product team.


18-24: Confirm licensing details for Qwen272BInstruct with legal to ensure compliance with the Tongyi Qianwen LICENSE AGREEMENT.

@@ -134,7 +138,7 @@ public static class OpenRouterModelProvider
{ OpenRouterModelIds.Xwin70B, new ChatModels("xwin-lm/xwin-lm-70b",8192,3.75E-06,3.75E-06)},
{ OpenRouterModelIds.MistralMistral7BInstructFree, new ChatModels("mistralai/mistral-7b-instruct:free",32768,0,0)},
{ OpenRouterModelIds.OpenAiGpt35TurboInstruct, new ChatModels("openai/gpt-3.5-turbo-instruct",4095,1.5E-06,2E-06)},
{ OpenRouterModelIds.MistralMistral7BInstructV01, new ChatModels("mistralai/mistral-7b-instruct-v0.1",8000,2.0000000000000002E-07,2.0000000000000002E-07)},
{ OpenRouterModelIds.MistralMistral7BInstructV01, new ChatModels("mistralai/mistral-7b-instruct-v0.1",4096,2.0000000000000002E-07,2.0000000000000002E-07)},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for potential duplication or misconfiguration in MistralMistral7BInstructV01.

The addition of MistralMistral7BInstructV01 seems to overlap with other versions of MistralMistral7BInstruct. Please ensure there is no duplication or configuration error, especially if the parameters are intended to differ between versions.

@github-actions github-actions bot merged commit b238bc0 into main Jun 10, 2024
3 checks passed
@github-actions github-actions bot deleted the bot/update-open-router_202406100624 branch June 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant