feat:Updated Together AI models #336
Conversation
WalkthroughThe recent changes introduce new models and update existing ones in the TogetherAI provider. Specifically, new classes for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/Providers/TogetherAI/src/Predefined/AllModels.cs (4 hunks)
- src/Providers/TogetherAI/src/TogetherAiModelIds.cs (4 hunks)
- src/Providers/TogetherAI/src/TogetherAiModelProvider.cs (3 hunks)
Additional comments not posted (9)
src/Providers/TogetherAI/src/TogetherAiModelProvider.cs (3)
31-31: The addition ofQwen2Instruct72Bmodel configuration looks correct and aligns with the PR's objective to update and add new models.
57-57: The configuration forReservedDbrxInstructis added correctly. However, ensure that the memory allocation (0) is intentional and appropriate for this model.
79-79: The updated configuration forMetaLlama370BChatappears to be in line with the intended enhancements. Confirm that the updated parameters meet the expected performance and resource usage criteria.src/Providers/TogetherAI/src/Predefined/AllModels.cs (3)
98-100: The classQwen2Instruct72BModelhas been added correctly and follows the established pattern for model class declarations.
228-230: The classReservedDbrxInstructModelis correctly declared. Ensure that the provider instance passed to it is configured to handle the specific needs of this model.
338-340: The update toMetaLlama370BChatModelis appropriate. Verify that the provider instance is correctly configured to support the new parameters of this model.src/Providers/TogetherAI/src/TogetherAiModelIds.cs (3)
218-227: The addition ofQwen2Instruct72Bis well-documented and follows the established metadata format. Good job maintaining consistency.
504-513: The addition ofReservedDbrxInstructis complete with all required metadata. Consider adding a note or comment in the documentation to explain the "Reserved" status if it has specific implications or restrictions.
746-755: The addition ofMetaLlama370BChatis well-documented. Ensure that the modified configurations mentioned in the AI-generated summary are reflected and verified in the model provider's configuration file.Verification successful
The addition of
MetaLlama370BChatis well-documented. Ensure that the modified configurations mentioned in the AI-generated summary are reflected and verified in the model provider's configuration file.#!/bin/bash # Description: Verify the configuration changes for `MetaLlama370BChat` in the model provider's configuration file. # Test: Search for the configuration details. Expect: Updated configuration details for `MetaLlama370BChat`. rg --type csharp $'MetaLlama370BChat' src/Providers/TogetherAI/src/TogetherAiModelProvider.cs-->
The configuration details forMetaLlama370BChathave been found in theTogetherAiModelProvider.csfile, confirming the update:
{ TogetherAiModelIds.MetaLlama370BChat, new ChatModels("meta-llama/Llama-3-70b-chat-hf",8192,9.000000000000001E-07,9.000000000000001E-07)}This indicates that the model ID and its associated configurations have been correctly added.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the configuration changes for `MetaLlama370BChat` in the model provider's configuration file. # Test: Search for the configuration details. Expect: Updated configuration details for `MetaLlama370BChat`. rg --type csharp $'MetaLlama370BChat' src/Providers/TogetherAI/src/TogetherAiModelProvider.csLength of output: 240
Created by Github Actions
Summary by CodeRabbit
New Features
Enhancements