feat(ecmascript): Implement Annex-B string prototype methods #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Jan 19, 2025
I also added some feature flags for including parts of or the whole of annex-b. Made them on-by-default, but might make more sense for them to be off?
eliassjogreen
force-pushed
the
feat/ecmascript-annex-b-string-methods
branch
from
f22b3ff to
61ce8a8
Compare
|
There are no expectations updated because we have turned off Annex B in the test runner, I ran it locally and it passed the string expectations, but I don't suppose we want to turn it on for the whole engine. |
aapoalas
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Looks mostly good to me, but let's change the function identities to match what the spec expects since it should be fairly easy to do.
We could also add the feature flag to the tests build and (eventually at least) turn on Annex B testing, but indeed let's not turn it on by default for the cli build. Don't want that whole mess.
We could also make PR to https://github.com/test262-fyi/test262.fyi/blob/main/scripts/engines/nova.sh to run with the Annex B feature flags.
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some feature flags for including parts of or the whole of annex-b. Made them on-by-default, but might make more sense for them to be off?