Close minor issues before release #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through try/except handling, errors preparing individual ECMs or ECM packages are now captured and written out to a TXT file in a new ./logs folder. Skipped ECMs are also now registered to a new list (“skipped”) in ./generated/run_setup.json, and users are warned if there are any wqECMs in this list when executing run.py. Fixes #255. Additionally, pulled check_mkt_inputs() function out of fill_mkts() such that it is executed across all ECMs in the site before individual ECM markets are prepared. Fixes #369.
The read-in of individual measure JSON now checks for duplicate keys and raises an error if present. Fixes #210. The check_mkt_inputs function was broadened to check key measure inputs (market entry year, performance, cost, lifetime, and market scaling fraction) in addition to checking for valid market inputs. Fixes #211.
jtlangevin
requested review from
trynthink and
aspeake
and removed request for
aspeake
aspeake
reviewed
Mar 14, 2024
aspeake
reviewed
Mar 14, 2024
Comment on lines
+13917
to
+13920
| "WARNING: " + | ||
| str(len(handyvars.skipped_ecms)) + single_plural + | ||
| "not prepared due to exceptions. See TXT file with the " | ||
| "appropriate timestamp in ./logs for details.") |
There was a problem hiding this comment.
So could there be multiple log files during a single run of ecm_prep.py? I though they would all be in one file
There was a problem hiding this comment.
It's all in one file per run, but with a unique time stamp. So each run of ecm_prep would get its own file. Make sense?
There was a problem hiding this comment.
This would be a task for #373, but it might make sense to write logs as "<timestamp>_<my_yaml_name>.txt". When running in batches as it could be confusing to look through logs otherwise.
aspeake
reviewed
Mar 14, 2024
aspeake
reviewed
Mar 14, 2024
aspeake
reviewed
Mar 14, 2024
jtlangevin
force-pushed
the
minor-issues
branch
from
50c6d68
to
6e1368f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to close issues #211, #210, #369, and #255.
Note that code on master does not currently pass the pycodestyle lint, which is causing CI build on these commits to fail.