Skip to content

Commit

Permalink
Bring managed outbound ips validation in line with other numeric vali…
Browse files Browse the repository at this point in the history
…dation
  • Loading branch information
tsatam committed Sep 21, 2023
1 parent f3668a5 commit f0636fb
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions python/az/aro/azext_aro/_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ def validate_version_format(namespace):


def validate_load_balancer_managed_outbound_ip_count(namespace):
if namespace.load_balancer_managed_outbound_ip_count is not None:
if namespace.load_balancer_managed_outbound_ip_count < 1 or namespace.load_balancer_managed_outbound_ip_count > 20: # pylint: disable=line-too-long
raise InvalidArgumentValueError('--load-balancer-managed-outbound-ip-count must be between 1 and 20 (inclusive).') # pylint: disable=line-too-long
if namespace.load_balancer_managed_outbound_ip_count is None:
return

minimum_managed_outbound_ips = 1
maximum_managed_outbound_ips = 20
if namespace.load_balancer_managed_outbound_ip_count < minimum_managed_outbound_ips or namespace.load_balancer_managed_outbound_ip_count > maximum_managed_outbound_ips: # pylint: disable=line-too-long
error_msg = f"--load-balancer-managed-outbound-ip-count must be between {minimum_managed_outbound_ips} and {maximum_managed_outbound_ips} (inclusive)." # pylint: disable=line-too-long
raise InvalidArgumentValueError(error_msg)

0 comments on commit f0636fb

Please sign in to comment.