fix: translate component mesh vertices to world coordinates and creat…#57
Open
bossco7598 wants to merge 1 commit intotscircuit:mainfrom
Open
fix: translate component mesh vertices to world coordinates and creat…#57bossco7598 wants to merge 1 commit intotscircuit:mainfrom
bossco7598 wants to merge 1 commit intotscircuit:mainfrom
Conversation
…e separate STEP solids per component Fixes tscircuit#6 - Missing rectangles in STEP output Root cause: mesh triangles from convertCircuitJsonTo3D are in local coordinates relative to each component box center, but the code treated them as world coordinates. Components near origin appeared correct by coincidence, while components elsewhere were rendered at origin (hidden inside the board). Changes: - Translate mesh vertices by box.center offset before processing - Create separate ClosedShell and ManifoldSolidBrep per component (fixes invalid topology from merging disconnected components into one shell) All 11 tests pass.
|
@bossco7598 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e separate STEP solids per component
Fixes #6 - Missing rectangles in STEP output
Root cause: mesh triangles from convertCircuitJsonTo3D are in local coordinates relative to each component box center, but the code treated them as world coordinates. Components near origin appeared correct by coincidence, while components elsewhere were rendered at origin (hidden inside the board).
Changes:
All 11 tests pass.