add tsconfig resolution higher in eval #1285
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| } | ||
|
|
||
| if (importName.startsWith("@tsci/")) { | ||
| return importSnippet(importName, ctx, depth) |
There was a problem hiding this comment.
The new path‑alias check runs before the @tsci/ snippet handling. If a project has a wildcard alias such as "@*": ["packages/*"] (common in monorepos to target all scoped packages), matchesTsconfigPathPattern will treat @tsci/... as an alias hit and the function now throws before reaching importSnippet. In previous behavior snippets were imported before the alias guard, so they worked even with broad aliases. This change will cause the evaluator to throw on any @tsci/* import whenever a broad alias exists, breaking snippet resolution for those projects.
Useful? React with 👍 / 👎.
1 participant
No description provided.