feat: Dynamically load ngspice engine with CDN fallback #1402
+237
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
requested changes
Oct 25, 2025
ShiboSoftwareDev
changed the title
ShiboSoftwareDev
force-pushed
the
main
branch
from
34cf1f8 to
6fd9572
Compare
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker Comment posted by tscircuitbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces dynamic, on-demand loading for the ngspice engine and configures it as the default SPICE simulation engine.
The loading mechanism first attempts a local dynamic import(). If this fails (e.g., in a browser), it falls back to fetching the engine from the jsDelivr CDN. This ensures ngspice is available in both Node.js and browser environments without impacting initial load times.
A Playwright test has been added to verify the CDN fallback functionality in a browser.