fix: Bootstrap w/ API for sending payment by SyedHannanMehdi · Pull Request #5 · tscircuit/fake-algora

SyedHannanMehdi · 2026-03-29T20:13:44Z

Automated fix for #1 — implemented by CashClaw agent.

Closes #1

Copilot

Pull request overview

This PR bootstraps a mock “Algora-like” API server to support bounty listing/creation and sending payments, aligning with Issue #1 (“Bootstrap w/ API for sending payment”).

Changes:

Replaces the prior project setup with a TypeScript + Express server (entrypoint + app + routers).
Adds an in-memory Store with seeded bounty data plus /bounties and /payments routes.
Adds initial Vitest/Supertest coverage for /bounties and updates TS/build configuration.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tsconfig.json	Switches to a Node/TS build output (`dist`) targeting ES2020/commonjs with declarations & sourcemaps.
package.json	Reworks package metadata and scripts for Express runtime + TypeScript build + Vitest tests.
src/app.ts	Creates the Express app, JSON middleware, routes, and 404 handler.
src/index.ts	Adds the server listener and startup logging.
src/types.ts	Introduces shared types for bounties, payments, and API shapes.
src/store.ts	Implements an in-memory store with seed data and CRUD helpers.
src/routes/bounties.ts	Adds `/bounties` list/get/create endpoints with Zod validation.
src/routes/payments.ts	Adds `/payments` list/get and `/payments/send` payment creation endpoint.
src/routes/bounties.test.ts	Adds Vitest/Supertest tests for the `/bounties` endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T20:18:03Z

src/routes/payments.ts

+  if (!result.success) {
+    return res
+      .status(400)
+      .json({ error: "Invalid request body", details: result.error.format() });


This endpoint returns details: result.error.format() on validation failure, but ApiError.details is typed as string in src/types.ts. Either change the response to a string (e.g. result.error.message) or widen the type of details to match what the API actually returns.

Suggested change

.json({ error: "Invalid request body", details: result.error.format() });

.json({ error: "Invalid request body", details: result.error.message });

Copilot · 2026-03-29T20:18:03Z

src/routes/payments.ts

+  const { bounty_id, recipient_username, amount_usd, currency } = result.data;
+
+  // Validate the bounty exists
+  const bounty = store.getBounty(bounty_id);
+  if (!bounty) {
+    return res
+      .status(404)
+      .json({ error: "Bounty not found", details: `No bounty with id "${bounty_id}"` });
+  }
+
+  // Guard: don't allow double-payment
+  if (bounty.status === "paid") {
+    return res.status(409).json({
+      error: "Bounty already paid",
+      details: `Bounty "${bounty_id}" has already been marked as paid`,
+    });
+  }
+
+  // Create payment record (simulate async processing → immediately complete)
+  const payment = store.createPayment({
+    bounty_id,
+    recipient_username,
+    amount_usd,
+    currency,
+    status: "completed",
+    transaction_id: `txn_${uuidv4().replace(/-/g, "").slice(0, 16)}`,
+  });


amount_usd, currency, and recipient_username are accepted from the request body even though the bounty already has amount/currency (and possibly an assigned recipient). This can create inconsistent records (paying a bounty for the wrong amount/currency/recipient). Consider deriving these fields from the bounty (or at least validating they match) before creating the payment and marking the bounty as paid.

Copilot · 2026-03-29T20:18:04Z

src/routes/bounties.ts

+  if (!result.success) {
+    return res
+      .status(400)
+      .json({ error: "Invalid request body", details: result.error.format() });


This route also returns details: result.error.format() (an object), which doesn't match the ApiError.details?: string type in src/types.ts. Align the runtime response shape and the exported types (either return a string message or widen the details type).

Suggested change

.json({ error: "Invalid request body", details: result.error.format() });

.json({

error: "Invalid request body",

details: JSON.stringify(result.error.format()),

});

Copilot · 2026-03-29T20:18:04Z

src/routes/bounties.test.ts

+  it("returns seeded bounties when store is populated", async () => {
+    store.createBounty({
+      issue_number: 1,
+      repo: "tscircuit/fake-algora",
+      amount_usd: 10,
+      currency: "USD",
+      status: "open",
+      recipient_username: null,
+    });


Test name is misleading: the store is reset in beforeEach, so this test isn't using seeded bounties; it's creating one explicitly. Rename the test (or adjust setup) so the description matches the behavior.

Copilot · 2026-03-29T20:18:04Z

src/routes/payments.ts

+router.post("/send", (req, res) => {
+  const result = SendPaymentSchema.safeParse(req.body);
+  if (!result.success) {
+    return res
+      .status(400)
+      .json({ error: "Invalid request body", details: result.error.format() });
+  }
+
+  const { bounty_id, recipient_username, amount_usd, currency } = result.data;
+
+  // Validate the bounty exists
+  const bounty = store.getBounty(bounty_id);
+  if (!bounty) {
+    return res
+      .status(404)
+      .json({ error: "Bounty not found", details: `No bounty with id "${bounty_id}"` });
+  }
+
+  // Guard: don't allow double-payment
+  if (bounty.status === "paid") {
+    return res.status(409).json({
+      error: "Bounty already paid",
+      details: `Bounty "${bounty_id}" has already been marked as paid`,
+    });
+  }
+
+  // Create payment record (simulate async processing → immediately complete)
+  const payment = store.createPayment({
+    bounty_id,
+    recipient_username,
+    amount_usd,
+    currency,
+    status: "completed",
+    transaction_id: `txn_${uuidv4().replace(/-/g, "").slice(0, 16)}`,
+  });
+
+  // Update bounty status
+  store.updateBounty(bounty_id, {
+    status: "paid",
+    recipient_username,
+  });
+
+  res.status(201).json({
+    payment,
+    message: `Payment of $${amount_usd} ${currency} sent to @${recipient_username} for bounty ${bounty_id}`,
+  });
+});


POST /payments/send introduces new behavior (payment creation, double-payment guard, bounty status update) but there are no corresponding Vitest/Supertest tests. Add tests for success, invalid body (400), unknown bounty (404), and already-paid bounty (409) to prevent regressions.

Copilot · 2026-03-29T20:18:04Z

src/index.ts

@@ -0,0 +1,14 @@
+import app from "./app";
+
+const PORT = process.env.PORT ?? 3000;


process.env.PORT is a string when set; passing it directly to app.listen can make Node treat it as a pipe name (e.g. "3000") instead of port 3000. Parse/coerce to a number (and validate it) before calling listen to avoid binding to the wrong endpoint.

Suggested change

const PORT = process.env.PORT ?? 3000;

const PORT = Number(process.env.PORT) || 3000;

Copilot · 2026-03-29T20:18:04Z

package.json

+    "test": "vitest run",
+    "test:watch": "vitest"


The test script runs vitest, but the repo still contains existing tests/**/*.test.ts that import bun:test (and other Bun-only tooling). With the current setup, vitest run will try to execute those files and fail. Either migrate/replace the Bun tests, or configure Vitest's include/exclude patterns so it only runs the intended Vitest/Supertest tests.

Suggested change

"test": "vitest run",

"test:watch": "vitest"

"test": "vitest run --exclude tests/**/*.test.ts",

"test:watch": "vitest --exclude tests/**/*.test.ts"

…type

…uards, use string details

…tests

…ll new behaviors

…ndPaymentInput

…ApiError.details type

…uble-pay & missing recipient

…tion/persistence

…d, POST /payments/send

SyedHannanMehdi added 9 commits March 30, 2026 01:42

chore: add package.json

415a869

chore: add tsconfig.json

82ed15b

feat: add shared types

7e66ec3

feat: add in-memory store with seed data

15d1fe5

feat: add bounties router

ebafa74

feat: add payments router with send endpoint

bc43957

feat: add express app with routing

7bf477a

feat: add server entry point

7033d84

test: add bounties route tests

edf17a3

Copilot AI reviewed Mar 29, 2026

View reviewed changes

SyedHannanMehdi added 20 commits March 30, 2026 01:53

fix: widen ApiError.details to string (aligns runtime and type)

8465ce3

fix: use result.error.message (string) for details to match ApiError …

c59dbf9

…type

fix: derive payment fields from bounty, add double-pay/no-recipient g…

c64f31d

…uards, use string details

feat: add updateBountyStatus helper and reset() for test isolation

9232add

fix: rename misleading test; add 404, validation, and field-coverage …

0ed57a2

…tests

test: add comprehensive /payments and /payments/send tests covering a…

de98d70

…ll new behaviors

chore: add package.json

726ebbe

chore: add tsconfig.json

b6cf67e

feat: add shared TypeScript types

139368b

feat: add in-memory store with payment simulation

3bc0542

feat: add error handler middleware

55c8a89

feat: add payments router with send-payment endpoint

797f0ea

feat: add bounties router (CRUD)

1b22413

feat: create Express app factory

91f2510

feat: add server entry point

fbe9f3e

fix(types): widen ApiError.details to string | Record and simplify Se…

eba448e

…ndPaymentInput

fix(bounties): keep details as format() object — now matches widened …

d6036ad

…ApiError.details type

fix(payments): derive amount/currency/recipient from bounty, guard do…

0625c0d

…uble-pay & missing recipient

feat(store): add updateBountyStatus helper and expose reset() for tests

1a45086

test(bounties): fix misleading test name, add coverage for 404/valida…

c35165a

…tion/persistence

test(payments): add full coverage for GET /payments, GET /payments/:i…

c072b7d

…d, POST /payments/send

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Bootstrap w/ API for sending payment#5

fix: Bootstrap w/ API for sending payment#5
SyedHannanMehdi wants to merge 30 commits intotscircuit:mainfrom
SyedHannanMehdi:cashclaw/fix-1-bootstrap-w-api-for-sendi

SyedHannanMehdi commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	.json({ error: "Invalid request body", details: result.error.format() });
	.json({ error: "Invalid request body", details: result.error.message });

		@@ -0,0 +1,14 @@
		import app from "./app";

		const PORT = process.env.PORT ?? 3000;

	const PORT = process.env.PORT ?? 3000;
	const PORT = Number(process.env.PORT) \|\| 3000;

Conversation

SyedHannanMehdi commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants