fix: standardize net names and resolve React key warnings#16
Closed
1028bc wants to merge 1 commit intotscircuit:mainfrom
Closed
fix: standardize net names and resolve React key warnings#161028bc wants to merge 1 commit intotscircuit:mainfrom
1028bc wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Updated the VDD connection in LedCircuit to use "net.V3_3". - This ensures alignment with the global power net defined in the VoltageRegulator and prevents disconnected nets in the final PCB routing.
Author
|
Closing this in favor of #19, which provides a consolidated fix for the geometry crashes, React warnings, and switch trace routing. All CI checks are passing there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two main issues:
Resolves the fatal build error Net name "3V3" cannot start with a number by standardizing all power rails to net.V3_3.
Fixes React 'unique key' warnings in the RP2040Circuit by adding keys to the decoupling capacitor map.
Verified that naming is consistent across LedCircuit, RP2040Circuit, and VoltageRegulator.