fix: finalize geometry and resolve build errors#18
Closed
1028bc wants to merge 2 commits intotscircuit:mainfrom
Closed
fix: finalize geometry and resolve build errors#181028bc wants to merge 2 commits intotscircuit:mainfrom
1028bc wants to merge 2 commits intotscircuit:mainfrom
Conversation
- Removed the '_innerhole' parameter from the stampboard footprint. - This bypasses the PhasedPackSolver error 'Cannot complete boolean operation' caused by unsupported plated hole shapes in the current engine version.
- Added 'pcbPack' to the <board> tag in index.tsx to resolve the 'Cannot complete boolean operation' error by preventing component overlap at the origin. - Imported and added the <KeyCircuit /> component to ensure it is rendered in the final PCB layout. - Removed unused RP2040 import to clean up the file.
Author
|
Triggering rebuild for React key fix |
Author
|
Closing this in favor of #19, which provides a consolidated fix for the geometry crashes, React warnings, and switch trace routing. All CI checks are passing there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes power nets to net.V3_3, removes unsupported circular hole geometry from the stampboard footprint, and adds pcbPack to the board to resolve geometry engine crashes.