feat: implement TraceCombineSolver to merge same-net trace segments (…#165
Open
RachitSinghh wants to merge 2 commits intotscircuit:mainfrom
Open
feat: implement TraceCombineSolver to merge same-net trace segments (…#165RachitSinghh wants to merge 2 commits intotscircuit:mainfrom
RachitSinghh wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
"I've fixed the formatting and updated the snapshots. All checks are now passing. Ready for another review! @rushabhcodes |
Author
|
@rushabhcodes hello have you checked it yet? |
|
for us to review this you would need to have at the very least some before/after snapshot tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#29)
/claim #29