Add new component SM04B_SRSS_TB_LF__SN2 and update circuit to use it#262
Open
rushabhcodes wants to merge 1 commit into
Open
Conversation
seveibar
requested changes
Feb 21, 2026
seveibar
left a comment
Contributor
There was a problem hiding this comment.
why do we have two of the same component?
There was a problem hiding this comment.
Pull request overview
This pull request adds a new variant component for the SM04B_SRSS_TB_LF connector and updates the SparkFun Ambient Light Sensor VEML7700 board to use it. The changes improve the CAD model alignment by providing two connector variants with opposite position offsets to accommodate different physical orientations on the PCB.
Changes:
- Added new component
SM04B_SRSS_TB_LF__SN2with CAD modelpositionOffsetof{ x: 0, y: 1.5, z: 0 } - Updated
SM04B_SRSS_TB_LF__SNCAD modelpositionOffsetfrom{ x: -1.5, y: -0.5, z: 0 }to{ x: 0, y: -1.5, z: 0 } - Modified circuit to use the new
SM04B_SRSS_TB_LF__SN2component for the JP2 connector
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SM04B_SRSS_TB_LF__SN2.tsx | New connector variant component with CAD model y-offset of 1.5mm |
| SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit.tsx | Updated to import and use the new SM04B_SRSS_TB_LF__SN2 component for JP2 |
| SM04B_SRSS_TB_LF__SN.tsx | Corrected CAD model positionOffset to align with the pattern used across other boards |
| SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit-3d.snap.png | Updated 3D snapshot reflecting the new CAD model positioning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new variant component for the SM04B_SRSS_TB_LF connector and updates its usage in the circuit definition for the SparkFun Ambient Light Sensor board. The main focus is on improving the footprint and pin arrangement for the connector. Below are the most important changes:
Component Addition and Circuit Update
SM04B_SRSS_TB_LF__SN2with enhanced footprint details, updated pin labels, and improved CAD model offsets inSM04B_SRSS_TB_LF__SN2.tsx.SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit.tsxto use the newSM04B_SRSS_TB_LF__SN2component instead of the originalSM04B_SRSS_TB_LF__SN. [1] [2]Footprint and CAD Model Improvements
positionOffsetfor the originalSM04B_SRSS_TB_LF__SNcomponent to improve alignment, changing it from{ x: -1.5, y: -0.5, z: 0 }to{ x: 0, y: -1.5, z: 0 }inSM04B_SRSS_TB_LF__SN.tsx.positionOffsetfor the newSM04B_SRSS_TB_LF__SN2component to{ x: 0, y: 1.5, z: 0 }for better placement in the CAD model.These changes improve the accuracy and usability of the connector footprint and its integration in the board design.