Skip to content

Add new component SM04B_SRSS_TB_LF__SN2 and update circuit to use it#262

Open
rushabhcodes wants to merge 1 commit into
tscircuit:mainfrom
rushabhcodes:fix-SparkFun-Ambient-Light-Sensor-VEML7700-Qwiic
Open

Add new component SM04B_SRSS_TB_LF__SN2 and update circuit to use it#262
rushabhcodes wants to merge 1 commit into
tscircuit:mainfrom
rushabhcodes:fix-SparkFun-Ambient-Light-Sensor-VEML7700-Qwiic

Conversation

@rushabhcodes

@rushabhcodes rushabhcodes commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces a new variant component for the SM04B_SRSS_TB_LF connector and updates its usage in the circuit definition for the SparkFun Ambient Light Sensor board. The main focus is on improving the footprint and pin arrangement for the connector. Below are the most important changes:

Component Addition and Circuit Update

  • Added a new component SM04B_SRSS_TB_LF__SN2 with enhanced footprint details, updated pin labels, and improved CAD model offsets in SM04B_SRSS_TB_LF__SN2.tsx.
  • Updated the circuit definition in SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit.tsx to use the new SM04B_SRSS_TB_LF__SN2 component instead of the original SM04B_SRSS_TB_LF__SN. [1] [2]

Footprint and CAD Model Improvements

  • Adjusted the positionOffset for the original SM04B_SRSS_TB_LF__SN component to improve alignment, changing it from { x: -1.5, y: -0.5, z: 0 } to { x: 0, y: -1.5, z: 0 } in SM04B_SRSS_TB_LF__SN.tsx.
  • Set the positionOffset for the new SM04B_SRSS_TB_LF__SN2 component to { x: 0, y: 1.5, z: 0 } for better placement in the CAD model.

These changes improve the accuracy and usability of the connector footprint and its integration in the board design.

image

Copilot AI review requested due to automatic review settings February 21, 2026 20:15

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have two of the same component?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new variant component for the SM04B_SRSS_TB_LF connector and updates the SparkFun Ambient Light Sensor VEML7700 board to use it. The changes improve the CAD model alignment by providing two connector variants with opposite position offsets to accommodate different physical orientations on the PCB.

Changes:

  • Added new component SM04B_SRSS_TB_LF__SN2 with CAD model positionOffset of { x: 0, y: 1.5, z: 0 }
  • Updated SM04B_SRSS_TB_LF__SN CAD model positionOffset from { x: -1.5, y: -0.5, z: 0 } to { x: 0, y: -1.5, z: 0 }
  • Modified circuit to use the new SM04B_SRSS_TB_LF__SN2 component for the JP2 connector

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
SM04B_SRSS_TB_LF__SN2.tsx New connector variant component with CAD model y-offset of 1.5mm
SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit.tsx Updated to import and use the new SM04B_SRSS_TB_LF__SN2 component for JP2
SM04B_SRSS_TB_LF__SN.tsx Corrected CAD model positionOffset to align with the pattern used across other boards
SparkFun-Ambient-Light-Sensor-VEML7700-(Qwiic).circuit-3d.snap.png Updated 3D snapshot reflecting the new CAD model positioning

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants