Correct TXS0108E footprint and add JLC sourcing#264
Open
rushabhcodes wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SparkFun Level Shifter (TXS0108E) board/chip definitions to improve the TXS0108E package footprint accuracy and add sourcing/3D metadata, alongside minor board configuration tweaks.
Changes:
- Reworked the
TXS0108EQWRKSRQ1chip footprint and addedsupplierPartNumbers.jlcpcbplus a CAD model reference. - Updated the board to disable routing and rotate the TXS0108E component for improved placement/orientation.
- Refreshed PCB/3D snapshot outputs to match the updated footprint/placement.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| boards/SparkFun-Level-Shifter-8-Channel-TXS0108E/TXS0108EQWRKSRQ1.tsx | Footprint overhaul + JLCPCB sourcing + CAD model metadata for the TXS0108E part. |
| boards/SparkFun-Level-Shifter-8-Channel-TXS0108E/SparkFun-Level-Shifter-8-Channel-TXS0108E.circuit.tsx | Board config update (routingDisabled) and pcbRotation adjustment for U1 placement. |
| boards/SparkFun-Level-Shifter-8-Channel-TXS0108E/snapshots/SparkFun-Level-Shifter-8-Channel-TXS0108E.circuit-pcb.snap.svg | Updated PCB snapshot reflecting the new footprint/placement. |
| boards/SparkFun-Level-Shifter-8-Channel-TXS0108E/snapshots/SparkFun-Level-Shifter-8-Channel-TXS0108E.circuit-3d.snap.png | Updated 3D snapshot reflecting the added CAD model and placement changes. |
Comments suppressed due to low confidence (1)
boards/SparkFun-Level-Shifter-8-Channel-TXS0108E/TXS0108EQWRKSRQ1.tsx:42
- The EP pad uses a near-zero scientific-notation Y coordinate ("1.1368683772161603e-13mm"), which is effectively 0 and adds noise to reviews/diffs. Consider normalizing tiny values like this to "0mm" (and similarly rounding other near-zero coordinates) to reduce churn while keeping the intended placement unchanged.
<smtpad
portHints={["pin21"]}
pcbX="0mm"
pcbY="1.1368683772161603e-13mm"
width="0.9999979999999999mm"
height="2.999994mm"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the TXS0108E chip and board definitions, focusing on footprint accuracy, supplier information, and board configuration. The main changes include a complete overhaul of the chip footprint, addition of supplier part numbers and CAD model, and updates to the board setup and component placement.
TXS0108E Chip Improvements
TXS0108EQWRKSRQ1chip footprint to use more precise pad locations and dimensions, ensuring better alignment with the actual device and PCB requirements.jlcpcbsupplier part number and a CAD model reference to the chip definition, improving sourcing and 3D visualization.Board and Component Placement
SparkFun-Level-Shifter-8-Channel-TXS0108E.circuit.tsxto disable routing, which may be useful for manual routing or specific design constraints.pcbRotationproperty for the TXS0108E component to 90 degrees, improving its orientation on the board.