fix: update position and rotation offsets for MST22D18G2_125 and TYPE_C_31_M_12 components#272
Open
rushabhcodes wants to merge 1 commit into
Open
fix: update position and rotation offsets for MST22D18G2_125 and TYPE_C_31_M_12 components#272rushabhcodes wants to merge 1 commit into
rushabhcodes wants to merge 1 commit into
Conversation
…_C_31_M_12 components
There was a problem hiding this comment.
Pull request overview
This PR refines 3D CAD model alignment for two components on the SparkFun USB-to-Serial Breakout (FT232RL) board so the rendered 3D view matches the intended placement/orientation.
Changes:
- Adjust TYPE_C_31_M_12 CAD model rotation (Z +180°) and translate along Y (+2.5).
- Adjust MST22D18G2_125 CAD model translate along Z (+0.85).
- Update/add the 3D render snapshot PNG for the board.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| boards/SparkFun-USB-to-Serial-Breakout-FT232RL/TYPE_C_31_M_12.tsx | Updates CAD model rotationOffset and positionOffset to correct USB-C connector orientation/placement. |
| boards/SparkFun-USB-to-Serial-Breakout-FT232RL/MST22D18G2_125.tsx | Updates CAD model positionOffset z to improve switch placement in 3D render. |
| boards/SparkFun-USB-to-Serial-Breakout-FT232RL/snapshots/SparkFun-USB-to-Serial-Breakout-FT232RL.circuit-3d.snap.png | Updates/adds the 3D snapshot to reflect the new CAD alignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
techmannih
reviewed
Mar 12, 2026
techmannih
left a comment
techmannih
left a comment
Member
There was a problem hiding this comment.
Lg, can you add cad model for the switch
Contributor
Author
the model exist and it also renders in 3d view but does not showup in snapshot |
Contributor
Author
|
@techmannih can we get this merged |
Member
|
Get approval from abse and shibo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes small adjustments to the 3D CAD model positioning and rotation for two board components to improve their alignment in the rendered view.
MST22D18G2_125.tsx, updated thepositionOffsetfor the MST22D18G2_125 component to shift it slightly along the z-axis for better placement.TYPE_C_31_M_12.tsx, adjusted both therotationOffset(rotating 180 degrees on the z-axis) and thepositionOffset(shifting 2.5 units along the y-axis) for the TYPE_C_31_M_12 component to correct its orientation and position.