feat: added example admin page at /_fake/admin#7
Closed
dhvll wants to merge 3 commits intotscircuit:mainfrom
dhvll:dev
Closed
feat: added example admin page at /_fake/admin#7dhvll wants to merge 3 commits intotscircuit:mainfrom dhvll:dev
dhvll wants to merge 3 commits intotscircuit:mainfrom
dhvll:dev
Conversation
…ed AdminPage component for managing items.
Anshgrover23
suggested changes
May 11, 2025
package.json
Outdated
| "typescript": "^5.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "immer": "^10.1.1", |
Contributor
There was a problem hiding this comment.
remove immer package why do we need this?
seveibar
reviewed
May 11, 2025
lib/middleware/with-react.ts
Outdated
| createElement( | ||
| "div", | ||
| null, | ||
| createElement( |
Contributor
There was a problem hiding this comment.
why would you do this instead of making this a tsx file?
seveibar
reviewed
May 11, 2025
| }), | ||
| })(async (req, ctx) => { | ||
| const things = ctx.db.things | ||
| return ctx.react(<AdminPage things={things} />) |
Contributor
There was a problem hiding this comment.
incorrect route spec, surprised this works
seveibar
reviewed
May 11, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
close, add support for deleting/adding a thing via jsonBody and you're good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/fix #4
/claim #4