-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shovill-se for processing single-end reads #105
Open
rpetit3
wants to merge
17
commits into
tseemann:master
Choose a base branch
from
rpetit3:single-end-reads
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he main shovill pipeline
bump to 1.0.7
Pull latest changes to Shovill
pull in latest changes
Bump to latest Shovill 1.1.0
This is really great, thanks! |
That's a great question, for some reason I had it in my head Lighter only supported paired-end reads. I'll get it added back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue: Support single-end (SE) reads #43
I went with
shovill-se
to avoid disrupting the mainshovill
pipeline, and I used--se|--single
to follow how SE reads work with Snippy.I've tested each of the assemblers and received expected outputs, but I would not be opposed to further testing (@lindechun you've mentioned interest in SE support)