Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geoUtils): add greek tax offices data and functions #64

Closed
wants to merge 19 commits into from
Closed

feat(geoUtils): add greek tax offices data and functions #64

wants to merge 19 commits into from

Conversation

DionisisChris
Copy link

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb17eb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tsevdos tsevdos self-requested a review March 20, 2024 10:55
@tsevdos tsevdos added the enhancement New feature or request label Mar 20, 2024
@DionisisChris
modified taxoffice data & added en version & greek string comparison …
99aeed5 
…& basic functions for taxoffices & some basic testing
@DionisisChris
Copy link
Author

More tests need to be added, maybe more functions and a general refinement.(Will also add a description in the pr)

tsevdos
tsevdos reviewed Apr 8, 2024
View reviewed changes
src/geoUtils.ts Outdated Show resolved Hide resolved
DionisisChris and others added 13 commits April 14, 2024 10:33
@DionisisChris @tsevdos
added tax offices data
68a4d38
@DionisisChris @tsevdos
modified taxoffice data & added en version & greek string comparison …
7df5b2d 
…& basic functions for taxoffices & some basic testing
@tsevdos
chore: code review suggestions
54453d5
@github-actions @DionisisChris
Version Packages (tsevdos#56)
844e6ad 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@tsevdos @DionisisChris
fix: github CI workflow (tsevdos#59)
a03d233
@tsevdos @DionisisChris
chore: cI github action trigger (tsevdos#60)
42ed90a
@tsevdos @DionisisChris
chore: bun runtime support (tsevdos#61)
b0b91b0
@tsevdos @DionisisChris
docs: add JSDoc annotations to functions (tsevdos#63)
fe1e939
@raptisj @DionisisChris
feat(formatUtils): add formatWeight utility function (tsevdos#67)
970b8b2 
* Add formatWeight to formatUtils module
* Correct docs
* Shorten tests
@github-actions @DionisisChris
Version Packages (tsevdos#68)
661b2a2 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@DionisisChris
Merge branch 'tsevdos:main' into main
5ff811a
@DionisisChris
Merge remote-tracking branch 'upstream/feat/tax-offices'
a64d699
@DionisisChris
Merge remote-tracking branch 'origin/main'
e0bae6f
@tsevdos tsevdos self-requested a review April 15, 2024 20:32
@DionisisChris
Copy link
Author

added the postal code function and more tests.

@tsevdos tsevdos changed the title Added tax offices data feat(geoUtils): add tax offices date and functions Apr 20, 2024
@tsevdos tsevdos changed the title feat(geoUtils): add tax offices date and functions feat(geoUtils): add greek tax offices data and functions Apr 20, 2024
tsevdos pushed a commit to DionisisChris/elUtils that referenced this pull request Apr 21, 2024
@DionisisChris
feat(geoUtils): add greek tax offices data and functions (tsevdos#64)
0a0e7e5 
* added tax offices data
* modified taxoffice data & added en version &  greek string comparison & basic functions for taxoffices & some basic testing
* chore: code review suggestions
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tsevdos
Copy link
Owner

tsevdos commented Apr 21, 2024

I couldn't manage to merge this branch (something went wrong with the main branch), but I created and successfully merged the feat/tax-offices branch (#76)

@tsevdos tsevdos closed this Apr 21, 2024
@tsevdos tsevdos mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsevdos tsevdos tsevdos approved these changes

Assignees

@DionisisChris DionisisChris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DionisisChris @tsevdos @raptisj