-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement helloworld bot #941
Open
hakatashi
wants to merge
9
commits into
master
Choose a base branch
from
helloworld
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakatashi
requested review from
platypus999,
kurgm,
hideo54,
satos---jp,
Yosshi999 and
settyan117
as code owners
October 3, 2024 06:35
Yosshi999
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
platypus999
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装したこと
slackbot開発時のAPIの動作確認、および他のBOTを開発する際の雛形として使えるBOT、「helloworld」を実装しました。
ユニットテストやESLintの設定など、Slackbotとして必要な最低限の機能が備わっています。
副次的修正
また、このBOTを作成する過程で Slack Node SDK を更新したところ、型定義がより厳密になったことでTypeScriptの型エラーが発生したため、slackbot全体のエラーを修正しました。
特に大きな修正点として、ChatPostMessageArgumentsの型定義が大幅に修正され、以下のようなオプション指定が不可となりました。
icon_url
とicon_emoji
を同時に指定するthread_ts
を指定せずにreply_broadcast
を指定するchannel
を指定しないこれらに基づいて各所のオプションの指定を修正しました。特にAteQuizの
solvedMessage
やunsolvedMessage
の指定ではthread_ts
を指定せずにreply_broadcast
を指定している部分が大半だったため、AteQuiz側でreply_broadcast
オプションの値を制御し、呼び出し側では指定しなくて良くなるようにしました。また、
WebAPICallOptions
が削除されたため、これも都度適切な型を参照するように修正しています。その他の修正内容
chat.update
メソッドの呼び出し時にusername
,icon_emoji
などを指定している部分を削除 (以前から指定する意味はなかったと思われる)username
などが必須のプロパティでなくなったため、テストなどでは in type guard を用いたコードに修正