Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to get_ll_representation signatures. #1010

Closed
jeromekelleher opened this issue May 11, 2020 · 0 comments · Fixed by #1038
Closed

Revert changes to get_ll_representation signatures. #1010

jeromekelleher opened this issue May 11, 2020 · 0 comments · Fixed by #1038
Assignees
@jeromekelleher
Labels
bug
Milestone
Release 1.0

Comments

@jeromekelleher
Copy link
Member

Recent changes made in #989 altered the signature of the get_ll_representation function in demographic models. It turns out that stdpopsim was using these functions.

Back out of the changes, and document the issue in the code so that we can update later once stdpopsim has been moved away from using this internal API.

popsim-consortium/stdpopsim#518
popsim-consortium/stdpopsim#522
@jeromekelleher jeromekelleher added this to the Release 1.0 milestone May 11, 2020
@jeromekelleher jeromekelleher self-assigned this May 11, 2020
This was referenced May 24, 2020
Closed
Open
jeromekelleher added a commit to mcveanlab/msprime that referenced this issue May 24, 2020
@jeromekelleher
Revert changes to DemographicModel API.
9da131a 
Closes tskit-dev#1010
jeromekelleher added a commit to mcveanlab/msprime that referenced this issue May 24, 2020
@jeromekelleher
Revert changes to DemographicModel API.
032fa9c 
Closes tskit-dev#1010
@jeromekelleher jeromekelleher mentioned this issue May 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromekelleher jeromekelleher

Labels
bug
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

Revert changes to DemographicModel API. mcveanlab/msprime
1 participant
@jeromekelleher